Gitea: Null Pointer Dereference in AddTime API Causes Authenticated Denial of Service
The AddTime API handler continues execution after an error returned by GetUserByName().
When a repository administrator specifies a non-existent user name, an error response is generated but execution does not stop. Subsequent code dereferences a nil user pointer, resulting in a runtime panic.
Affected endpoint:
POST /api/v1/repos/{owner}/{repo}/issues/{index}/times
Affected file:
routers/api/v1/repo/issue_tracked_time.go
Relevant code:
user, err = user_model.GetUserByName(ctx, form.User)
if err != nil {
ctx.APIErrorInternal(err)
// missing return
}
Execution continues to:
trackedTime, err := issues_model.AddTime(
ctx,
user,
issue,
form.Time,
created,
)
When GetUserByName() fails, user is nil.
The subsequent call dereferences the nil pointer and triggers a runtime panic.
Using a repository administrator account:
POST /api/v1/repos/owner/repo/issues/1/times
Content-Type: application/json
{
"time": 3600,
"user_name": "nonexistent_user_xyz"
}
Result:
HTTP 500
runtime error: invalid memory address or nil pointer dereference
The stack trace indicates execution reaches the AddTime code path with a nil user object.
An authenticated repository administrator can repeatedly trigger server-side panics through the affected endpoint.
Depending on deployment configuration and panic recovery behavior, this may result in request failures, stack trace disclosure, excessive log generation, or degraded service availability.
Add a return statement after the error response:
user, err = user_model.GetUserByName(ctx, form.User)
if err != nil {
ctx.APIErrorInternal(err)
return
}
为什么是这个 VPI(可解释·实验性)
VPI 计算依据
| 影响度 | 27.00 |
| 利用信号(无额外利用信号) | ×1.00 |
| VPI | 27.00 |
VPI 公式 vpi-v1